Add align='right' prop to SelectMenu.Modal#800
Merged
BinaryMuse merged 9 commits intorelease-19.0.0from May 7, 2020
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/g7t73yoo4 |
BinaryMuse
reviewed
May 5, 2020
Contributor
BinaryMuse
left a comment
BinaryMuse
left a comment
There was a problem hiding this comment.
This seems reasonable to me! 👍 One doc change and a fix to propTypes in suggestions below.
Co-authored-by: Michelle Tilley <binarymuse@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for aligning the menu of a
SelectMenuwith the right side of the button. This functionality exists currently in Primer/CSS (https://primer.style/css/components/select-menu#right-aligned), so this PR brings Primer/Components up to feature parity.The implementation is the same as the one in Primer/CSS, where a container should have
position: relativein order to align the absolutely positioned modal properly.Closes #795
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
index.d.ts) if necessaryTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.